Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidb support setting a random password. #4328
Tidb support setting a random password. #4328
Changes from 5 commits
88fc3b2
f9cb7fe
5b31a93
b5de123
324ffbf
ab37b18
d3e7898
41b888f
68f4994
c269faa
412dd41
280dab8
2fe7dfd
cb4d1d0
00cde54
d1fe63d
09d5b5a
417a0b4
bfba0ab
7b5cb24
5c18f22
7013280
45e1884
fee697a
501643e
afef7cd
3cc4750
e71840f
2cb2c9b
f61774f
c583907
0dee2e3
79d78a5
1bf113c
3d90a28
47b4489
f0e3701
1496f18
4e14c3d
63a30d7
6c40b18
3e6ef17
e1a45b8
587fedf
e6a15a7
fb5f93e
d87ff52
b9ae888
640b16f
3dda6f1
c7815fd
6517afa
427be40
0feac45
4ea3a08
9f4495e
00e42df
e1cf3fd
f58ba69
9c89860
49e7afc
a542c0a
a961848
44c7591
2707cfb
0b7d438
d7190ea
1111249
aecf90a
0f4a01a
56f3fc8
f36f667
fdb2411
d08c32c
9186b3d
6629a53
1d74087
be13332
066e064
d753684
993e9c6
8bb1e6d
590785c
86c50fb
1a7dd1b
1fda059
8f9156d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it better we define a
phase
in the status as we do for the initializer here https://github.com/pingcap/tidb-operator/blob/master/pkg/apis/pingcap/v1alpha1/tidbinitializer_types.go#L109 so that we can know if the password creation is ongoing, successful, or failed?The bool
InitPassword
cannot represent all the statuses.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok,i use same type as the phase field in tidbinitializer.