feat: force upgrade PD when PD replicas number is less than 2 #4107
Conversation
|
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
tests/e2e/tidbcluster/tidbcluster.go
Outdated
| return nil | ||
| }) | ||
| framework.ExpectNoError(err, "failed to upgrade TidbCluster: %q", tc.Name) | ||
| err = oa.WaitForTidbClusterReady(tc, 10*time.Minute, 5*time.Second) |
There was a problem hiding this comment.
still hard to check no gracefulUpgrade occurred?
There was a problem hiding this comment.
Yes, it's hard to check that, at least, the upgrade succeeds without adding annotation.
Codecov Report
@@ Coverage Diff @@
## master #4107 +/- ##
==========================================
+ Coverage 69.48% 70.37% +0.88%
==========================================
Files 182 182
Lines 21228 21231 +3
==========================================
+ Hits 14751 14942 +191
+ Misses 5326 5128 -198
- Partials 1151 1161 +10
|
tests/e2e/tidbcluster/tidbcluster.go
Outdated
| ginkgo.By(fmt.Sprintf("Force Upgrading tidb cluster from %s to %s with ignoring PD error", tc.Spec.Version, utilimage.TiDBLatest)) | ||
| err = controller.GuaranteedUpdate(genericCli, tc, func() error { | ||
| tc.Spec.PD.BaseImage = "pingcap/pd" | ||
| tc.Spec.Version = utilimage.TiDBLatest |
There was a problem hiding this comment.
No need to update the version.
# Conflicts: # tests/e2e/tidbcluster/tidbcluster.go
|
/run-all-tests |
|
/merge |
|
This pull request has been accepted and is ready to merge. Commit hash: 5d28000
|
|
/run-all-tests |
|
/test pull-e2e-kind |
1 similar comment
|
/test pull-e2e-kind |
|
@mianhk: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
|
/run-all-tests |
2 similar comments
|
/run-all-tests |
|
/run-all-tests |
|
/test pull-e2e-kind |
1 similar comment
|
/test pull-e2e-kind |
What problem does this PR solve?
close #1241
What is changed and how does it work?
Code changes
Tests
Side effects
Related changes
Release Notes
Please refer to Release Notes Language Style Guide before writing the release note.