-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add terraform script to auto deploy TiDB cluster on AWS #401
Conversation
This looks great! Rather than having it under a directory |
Awesome! AWS finally got some love! |
Block at creating tiller.
|
This should be integrated with the existing documentation for deploying to AWS EKS: https://github.com/pingcap/tidb-operator/blob/master/docs/aws-eks-tutorial.md |
Yes, it should be. But this PR still needs a lot of polish. |
@c4pt0r Did you follow the readme instructions to install aws-iam-authenticator? |
@gregwebs I've updated the code to move terraform scripts to |
|
I'm sure I successfully installed aws-iam-authenticator |
@c4pt0r Could you try to run |
Ok....but it really confused me...why 2 times? |
I left a comment on #436 wondering about our approach to templating the helm values file. |
74cb4c6
to
372cc6b
Compare
LGTM. |
I think we should template only the values necessary (e.g. cluster version is not) and let the user change the helm values directly. They need to know how to do that anyways. |
@gregwebs The |
@tennix yes. But why do you expose It seems like you are figuring out how to query K8s for information to put into terraform: could we eventually do that for the pd_count, etc also? |
The current deployment is for single TiDB cluster. We need another setup and documentation for deploying multiple TiDB clusters in the same EKS cluster. |
This PR adds initial support for one-click deploying Cloud TiDB on AWS. PTAL @gregwebs @onlymellb @weekface