Fix heterogeneous code cause tidb rolling update bug #3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3322 +/- ##
==========================================
+ Coverage 41.84% 41.89% +0.05%
==========================================
Files 159 159
Lines 16572 16690 +118
==========================================
+ Hits 6934 6992 +58
- Misses 8998 9045 +47
- Partials 640 653 +13
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/run-all-tests |
pkg/manager/member/template.go
Outdated
| @@ -77,6 +77,7 @@ exec /tidb-server ${ARGS} | |||
| `)) | |||
|
|
|||
| type TidbStartScriptModel struct { | |||
| ClusterName string | |||
There was a problem hiding this comment.
This is not used, right?
There was a problem hiding this comment.
Old logic have this field, i think it is unused. I can remove it.
ti-srebot
approved these changes
Sep 25, 2020
ti-srebot
pushed a commit
to ti-srebot/tidb-operator
that referenced
this pull request
Sep 25, 2020
Signed-off-by: ti-srebot <[email protected]>
|
cherry pick to release-1.1 in PR #3324 |
DanielZhangQD
pushed a commit
that referenced
this pull request
Sep 25, 2020
Signed-off-by: ti-srebot <[email protected]> Co-authored-by: Mike <[email protected]>
cvvz
pushed a commit
to cvvz/tidb-operator
that referenced
this pull request
Oct 18, 2020
* fix rolling update * remove unused field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix heterogeneous code cause tidb rolling update bug .
What is changed and how does it work?
Non-heterogeneous cluster tidb startup use the old address format.
Check List
Tests
Code changes