Add unit tests for dm cluster CRD, discovery service, dm-master/dm-worker member manager #3310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lichunzhu
requested review from
AstroProfundis,
lonng,
july2993 and
DanielZhangQD
Codecov Report
@@ Coverage Diff @@
## master #3310 +/- ##
==========================================
+ Coverage 41.89% 48.41% +6.51%
==========================================
Files 159 159
Lines 16690 16730 +40
==========================================
+ Hits 6992 8099 +1107
+ Misses 9045 7863 -1182
- Partials 653 768 +115
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
/test pull-e2e-kind |
|
/test pull-e2e-kind |
| @@ -539,7 +542,10 @@ func getNewMasterSetForDMCluster(dc *v1alpha1.DMCluster, cm *corev1.ConfigMap) ( | |||
| dcName := dc.Name | |||
| baseMasterSpec := dc.BaseMasterSpec() | |||
| instanceName := dc.GetInstanceName() | |||
| masterConfigMap := cm.Name | |||
| masterConfigMap := "" | |||
| if cm != nil { | |||
There was a problem hiding this comment.
What if cm is nil here, should we return error?
There was a problem hiding this comment.
I think it's unnecessary🤔
| @@ -360,7 +360,10 @@ func getNewWorkerSetForDMCluster(dc *v1alpha1.DMCluster, cm *corev1.ConfigMap) ( | |||
| dcName := dc.Name | |||
| baseWorkerSpec := dc.BaseWorkerSpec() | |||
| instanceName := dc.GetInstanceName() | |||
| workerConfigMap := cm.Name | |||
| workerConfigMap := "" | |||
| if cm != nil { | |||
| @@ -1173,7 +1173,7 @@ func TestGetNewMasterSetForDMCluster(t *testing.T) { | |||
|
|
|||
| for _, tt := range tests { | |||
| t.Run(tt.name, func(t *testing.T) { | |||
| sts, err := getNewMasterSetForDMCluster(&tt.dc, nil) | |||
There was a problem hiding this comment.
There should be a case to cover the nil cm case.
|
/test pull-e2e-kind |
AstroProfundis
approved these changes
Sep 27, 2020
ti-srebot
approved these changes
Sep 27, 2020
cvvz
pushed a commit
to cvvz/tidb-operator
that referenced
this pull request
Oct 18, 2020
…rker member manager (pingcap#3310) * add UT for dmcluster configurations, dmapi and dm-master/dm-worker member manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
#2868
Add UT part 1.
What is changed and how does it work?
Add unit tests for dm cluster CRD, discovery service, dm-master/dm-worker member manager.
Also fix some small bugs.
Check List
Tests
Code changes
Does this PR introduce a user-facing change?: