Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Monitor log error #2574

Merged
merged 4 commits into from
May 28, 2020
Merged

Fix Monitor log error #2574

merged 4 commits into from
May 28, 2020

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented May 27, 2020

What problem does this PR solve?

Fix the error when tidbmonitor sync PVC failed which will cause panic

Does this PR introduce a user-facing change?:

Fix the error when `TidbMonitor` sync `PVC` failed which will cause controller manager panic

@Yisaer Yisaer changed the title fix log error Fix Monitor log error May 27, 2020
@cofyc cofyc mentioned this pull request May 27, 2020
9 tasks
weekface
weekface previously approved these changes May 27, 2020
cofyc
cofyc previously approved these changes May 27, 2020
@Yisaer
Copy link
Contributor Author

Yisaer commented May 27, 2020

/merge

@Yisaer Yisaer dismissed stale reviews from cofyc and weekface via c66f6b6 May 27, 2020 10:52
@Yisaer Yisaer requested a review from weekface May 27, 2020 11:19
@Yisaer
Copy link
Contributor Author

Yisaer commented May 27, 2020

/run-e2e-in-kind

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 28, 2020

/run-all-tests

@sre-bot
Copy link
Contributor

sre-bot commented May 28, 2020

@Yisaer merge failed.

@Yisaer
Copy link
Contributor Author

Yisaer commented May 28, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented May 28, 2020

/run-all-tests

@sre-bot sre-bot merged commit 16e1de4 into pingcap:master May 28, 2020
@Yisaer
Copy link
Contributor Author

Yisaer commented May 28, 2020

/run-cherry-picker

sre-bot pushed a commit to sre-bot/tidb-operator that referenced this pull request May 28, 2020
@sre-bot
Copy link
Contributor

sre-bot commented May 28, 2020

cherry pick to release-1.1 in PR #2579

sre-bot added a commit that referenced this pull request May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants