Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more events for tidbcluster and autoscaler (#2150) #2181

Merged
merged 3 commits into from
Apr 15, 2020

Conversation

Yisaer
Copy link
Contributor

@Yisaer Yisaer commented Apr 14, 2020

What problem does this PR solve?

Close #2096
Add event for tidbcluster and auto-scaler.
For auto-scaler, we would send event if the auto-scaling is permitted.
For tidbcluster, we would send event for each component (pd/tikv/tidb)'s / failover.

Does this PR introduce a user-facing change?:

Emit more events for `TidbCluster` and `TidbClusterAutoScaler` to help users know TiDB running status

* add event for tidbcluster and auto-scaler

* fix unit test

* Update pkg/manager/member/upgrader.go

Co-Authored-By: DanielZhangQD <[email protected]>

* revise scaling logic

* revise logic

* fix failover event

* remove upgrading event

* remove scaling event

* remove unnecessary event

* remove useless code

* revert changes

Co-authored-by: DanielZhangQD <[email protected]>
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cofyc
Copy link
Contributor

cofyc commented Apr 15, 2020

/merge

@sre-bot
Copy link
Contributor

sre-bot commented Apr 15, 2020

/run-all-tests

@sre-bot sre-bot merged commit 1f305d2 into pingcap:release-1.1 Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants