Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TidbMonitor several error (#1962) #1985

Merged
merged 8 commits into from
Mar 19, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 19, 2020

cherry-pick #1962 to release-1.1


What problem does this PR solve?

Fix #1949

What is changed and how does it work?

Fix following problem:

  1. Add check to guaranteeing the nodePort won't be changed if the service Type of tidbmonitor is Nodeport
  2. Add EnvVar sort to avoid the monitor controller render different result from the same tidbmonitor spec.
  3. Add LB IP configuration rendering.
  4. Change the reloader servicename to keep as same as the helm template.

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

1. Add check to guaranteeing the nodePort won't be changed if the serviceType of TidbMonitor is Nodeport
2. Add EnvVar sort to avoid the monitor controller render different result from the same TidbMonitor spec.
3. Fix the problem that Tidbmonitor LoadBalance IP is not used.

@Yisaer Yisaer merged commit e669332 into pingcap:release-1.1 Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/monitor monitoring status/PTAL PR needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants