Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aws ami version link (#1903) #1918

Merged
merged 1 commit into from
Mar 13, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 12, 2020

cherry-pick #1903 to release-1.1


What problem does this PR solve?

fix #1607

What is changed and how does it work?

Add aws ami version link to the variable description so that users can know exactly which version to set if they want to.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    • terraform init, terraform validate, terraform apply works as expected.

Code changes

  • Has Terraform scripts change

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

NONE

@DanielZhangQD
Copy link
Contributor

/run-all-tests

@onlymellb
Copy link
Contributor

/merge

@sre-bot
Copy link
Contributor Author

sre-bot commented Mar 13, 2020

/run-all-tests

@sre-bot sre-bot merged commit 5b62f91 into pingcap:release-1.1 Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants