Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add timestamp annotation in tidbcluster statefulset (#1875) #1883

Merged
merged 14 commits into from
Mar 9, 2020

Conversation

sre-bot
Copy link
Contributor

@sre-bot sre-bot commented Mar 9, 2020

cherry-pick #1875 to release-1.1


What problem does this PR solve?

fixes #1846

When .Values.admission.validation.pods is enabled, the process of upgrading and scaling for pd and tikv would be controlled by the admission webhook.

And the admission webhook would face the problem that, as webhook would deny the request for deleting the pod if the tikv or the pd is not ready to be deleted, the interval duration between each 2 deleting request from sts controller would be much longer. This would cause the timeout error in our CI test. This request is to add the timestamp in each syncing in sts annotations to avoid this problem by adding the tidbcluster sts into the sts controller queue.

Does this PR introduce a user-facing change?:

Fix the timeout error when .Values.admission.validation.pods is true during tikv upgrading.

@cofyc cofyc merged commit 58752ab into pingcap:release-1.1 Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/webhook Related to webhook test/e2e e2e test type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants