-
Notifications
You must be signed in to change notification settings - Fork 499
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add consecutive count check for Auto-scaling (#1703) #1715
Merged
Yisaer
merged 19 commits into
pingcap:release-1.1
from
sre-bot:release-1.1-56daf5e80243
Feb 18, 2020
Merged
Add consecutive count check for Auto-scaling (#1703) #1715
Yisaer
merged 19 commits into
pingcap:release-1.1
from
sre-bot:release-1.1-56daf5e80243
Feb 18, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: DanielZhangQD <[email protected]>
Co-Authored-By: DanielZhangQD <[email protected]>
sre-bot
added
area/auto-scaling
related to auto-scaling
area/controller
status/PTAL
PR needs to be reviewed
type/1.1 cherry-pick
labels
Feb 17, 2020
sre-bot
requested review from
cofyc,
DanielZhangQD,
gregwebs,
onlymellb and
weekface
February 17, 2020 11:03
Yisaer
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #1703 to release-1.1
What problem does this PR solve?
ref #1651
Noteice
As
Auto-scaling
is under alpha feature, the first target is to achieve basic auto-scaling Availability.The extra control to avoid jitter for production-ready is not considered in this request. These could be recorded in this issue first.
#1651
What is changed and how does it work?
Add 3 new configuration for Auto-scaling API and default them them Controller.
ScaleOutThreshold/ScaleInThreshold is used to check the consecutive count in auto-scaling control to avoid jitter.
I also add the unit test for the current sync logic for tidb and tikv and the newly added function in
util.go
In this request, each auto-scaling reconciliation would record the consecutive count in the target tidbclusterAutoScaler annotations marked as ScaleOutCount / ScaleInCount
For example:
In one tikv auto-scaling reconciliation,
if recommended replicas > current replicas, then:
if recommended replicas < current replicas, then:
if recommended replicas == current replicas, then:
When the *ScaleOutCount/ *ScaleInCount is bigger than the defined property in autoscaler api, the auto-scaling would be performed and the record would be empty and recount.
Does this PR introduce a user-facing change?: