Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PD should be force upgraded when there's only one replica #1241

Closed
aylei opened this issue Nov 26, 2019 · 3 comments · Fixed by #4107
Closed

PD should be force upgraded when there's only one replica #1241

aylei opened this issue Nov 26, 2019 · 3 comments · Fixed by #4107
Assignees
Labels
area/controller status/WIP Issue/PR is being worked on type/bug Something isn't working
Milestone

Comments

@aylei
Copy link
Contributor

aylei commented Nov 26, 2019

Feature Request

Is your feature request related to a problem? Please describe:

Deploy TiDB cluster with only 1 PD Pod and bad configuration, PD crashLoopBackoff, correct the configuration, PD cluster cannot recover:

E1126 14:20:22.228535       1 tidb_cluster_controller.go:240] TidbCluster: csn/hot-new, sync failed tidbcluster: [csn/hot-new]'s pd status sync failed,can not to be upgraded, requeuing
E1126 14:20:47.802457       1 pd_member_manager.go:196] failed to sync TidbCluster: [csn/hot-new]'s status, error: Get http://hot-new-pd.csn:2379/pd/api/v1/cluster: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
E1126 14:20:47.803078       1 tidb_cluster_controller.go:240] TidbCluster: csn/hot-new, sync failed tidbcluster: [csn/hot-new]'s pd status sync failed,can not to be upgraded, requeuing
E1126 14:21:13.599951       1 pd_member_manager.go:196] failed to sync TidbCluster: [csn/hot-new]'s status, error: Get http://hot-new-pd.csn:2379/pd/api/v1/cluster: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
E1126 14:21:13.600222       1 tidb_cluster_controller.go:240] TidbCluster: csn/hot-new, sync failed tidbcluster: [csn/hot-new]'s pd status sync failed,can not to be upgraded, requeuing
E1126 14:21:42.100753       1 pd_member_manager.go:196] failed to sync TidbCluster: [csn/hot-new]'s status, error: Get http://hot-new-pd.csn:2379/pd/api/v1/cluster: net/http: request canceled while waiting for connection (Client.Timeout exceeded while awaiting headers)
E1126 14:21:42.101092       1 tidb_cluster_controller.go:240] TidbCluster: csn/hot-new, sync failed tidbcluster: [csn/hot-new]'s pd status sync failed,can not to be upgraded, requeuing

User have to manually add force-delete annotation to recover, which is tedious.

Describe the feature you'd like:

Perform force upgrade when replica is 1. There's no need to be "graceful" here because 1 replica don't have peers to transfer leader.

/cc @DanielZhangQD

@Yisaer Yisaer added the type/bug Something isn't working label Nov 27, 2019
@Yisaer Yisaer self-assigned this Nov 27, 2019
@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days

@github-actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days

@cofyc cofyc added the status/WIP Issue/PR is being worked on label Jun 8, 2020
@DanielZhangQD DanielZhangQD modified the milestone: v1.1.4 Jul 28, 2020
@DanielZhangQD DanielZhangQD modified the milestones: v1.3.0, v1.3.0-alpha.1 Jul 23, 2021
@mianhk
Copy link
Contributor

mianhk commented Jul 29, 2021

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller status/WIP Issue/PR is being worked on type/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants