Automated cherry pick of #915: Support configuring sysctls for Pods and enable net.* #1175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: weekface <[email protected]>
|
/run-e2e-in-kind |
tennix
reviewed
Nov 18, 2019
| Services []Service `json:"services,omitempty"` | ||
| PVReclaimPolicy corev1.PersistentVolumeReclaimPolicy `json:"pvReclaimPolicy,omitempty"` | ||
| Timezone string `json:"timezone,omitempty"` | ||
| MaxFailoverCount int32 `json:"maxFailoverCount,omitempty"` |
There was a problem hiding this comment.
Why add MaxFailoverCount in TidbCluster?
There was a problem hiding this comment.
Good catch, that's a typo when I fix the merge conflict in TiDBSpec
Signed-off-by: Aylei <[email protected]>
aylei
force-pushed
the
automated-cherry-pick-of-#915-upstream-release-1.0
branch
from
e4a2a90
to
99c47ba
Compare
…upstream-release-1.0
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #915 on release-1.0.
#915: Support configuring sysctls for Pods and enable net.*