Skip to content

Commit

Permalink
marketplace update (#380)
Browse files Browse the repository at this point in the history
* marketplace update

document the service account
fix some issues with the manual install

* add a note on deletion
  • Loading branch information
gregwebs authored and tennix committed Apr 17, 2019
1 parent baa2975 commit 147da0f
Show file tree
Hide file tree
Showing 2 changed files with 19 additions and 6 deletions.
20 changes: 19 additions & 1 deletion marketplace/gcp/tidb-operator/README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,21 @@
# GKE service account

If you install on GKE, please select the option to create a new service account.
The default service account may not have the required permissions.

# Deletion

In the below, tidb is installed into the namespace "tidb".
Deleting the application will not delete the pods. You should delete the namespace and then delete the persistent volumes.

```
kubectl delete namespace tidb
kubectl get pv -l app.kubernetes.io/namespace=$NAMESPACE -o name | xargs -I {} kubectl patch {} -p '{"spec":{"persistentVolumeReclaimPolicy":"Delete"}}'
```


# Manual installation

First you can modify configuration values.

* schema.yaml: don't modify this, use parameters to override it as shown below
Expand All @@ -24,7 +42,7 @@ NAMESPACE=tidb
# We strongly recommend deploying into a new namespace
kubectl create namespace $NAMESPACE

REGISTRY=$REGISTRY NAMESPACE=$NAMESPACE ./scripts/install
REGISTRY=$REGISTRY NAMESPACE=$NAMESPACE VERSION=$VERSION ./scripts/install
```

You can watch the deployment come up with
Expand Down
5 changes: 0 additions & 5 deletions marketplace/gcp/tidb-operator/manifests/app-crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,3 @@ spec:
type: object
type: object
version: v1beta1
status:
acceptedNames:
kind: ""
plural: ""
conditions: null

0 comments on commit 147da0f

Please sign in to comment.