Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

backend: update mysql backend to tidb backend #228

Merged
merged 2 commits into from
Aug 21, 2019
Merged

Conversation

WangXiangUSTC
Copy link
Contributor

What problem does this PR solve?

change the backend's name from tidb to mysql

What is changed and how it works?

update config, code file name and some variable name

Check List

Tests

  • Unit test
  • Integration test

Related changes

  • Need to update the documentation

@WangXiangUSTC WangXiangUSTC added status/PTAL This PR is ready for review. Add this label back after committing new changes priority/unimportant labels Aug 21, 2019
@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests

@WangXiangUSTC
Copy link
Contributor Author

/run-all-tests

@WangXiangUSTC
Copy link
Contributor Author

@kennytm PTAL

Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT1 One reviewer already commented LGTM (LGTM1) and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Aug 21, 2019
@kennytm kennytm requested a review from lance6716 August 21, 2019 10:32
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lance6716 lance6716 added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels Aug 21, 2019
@kennytm kennytm merged commit ce5fa5f into master Aug 21, 2019
@kennytm kennytm deleted the xiang/backend branch August 21, 2019 16:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants