This repository has been archived by the owner on Dec 8, 2021. It is now read-only.
restore: update and restore GCLifeTime once when parallel (#220) #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* restore: update and restore GCLifeTime once when parallel * Update lightning/restore/restore.go Co-Authored-By: amyangfei <[email protected]> * Update lightning/restore/restore.go Co-Authored-By: amyangfei <[email protected]> * Update lightning/restore/restore.go Co-Authored-By: amyangfei <[email protected]> * restore: fix bug in reviewing * restore: call ObtainGCLifeTime closer to use * restore: improve readabiilty * restore: reduce struct copy and pointer deref * restore: fix bug in reviewing * Update lightning/restore/restore.go Co-Authored-By: kennytm <[email protected]> * restore: improve readability * restore: refine mock expectation order * restore: adjust detail
…)" This reverts commit 9f36067.
* restore: update and restore GCLifeTime once when parallel * Update lightning/restore/restore.go Co-Authored-By: amyangfei <[email protected]> * Update lightning/restore/restore.go Co-Authored-By: amyangfei <[email protected]> * Update lightning/restore/restore.go Co-Authored-By: amyangfei <[email protected]> * restore: fix bug in reviewing * restore: call ObtainGCLifeTime closer to use * restore: improve readabiilty * restore: reduce struct copy and pointer deref * restore: fix bug in reviewing * Update lightning/restore/restore.go Co-Authored-By: kennytm <[email protected]> * restore: improve readability * restore: refine mock expectation order * restore: adjust detail
lance6716
added
2.1-cherry-pick
|
LGTM |
zier-one
added
status/LGT2
lance6716
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Cherry-pick #220 to release-2.1.
What is changed and how it works?
Check List
Tests
Side effects
Related changes