Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

Limit closed engine count for coordinating write and import #119

Merged
merged 9 commits into from
Feb 13, 2019
Merged

Limit closed engine count for coordinating write and import #119

merged 9 commits into from
Feb 13, 2019

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Jan 16, 2019

What problem does this PR solve?

Limit closed engine count for coordinating write and import

What is changed and how it works?

Apply a worker before call engine.Close() and release worker after engine.Cleanup

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Code changes

Side effects

Related changes

@sre-bot
Copy link

sre-bot commented Jan 16, 2019

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@lonng lonng added the status/DNM Do not merge, test is failing or blocked by another PR label Jan 16, 2019
@lonng
Copy link
Contributor Author

lonng commented Jan 16, 2019

/run-all-tests

@lonng
Copy link
Contributor Author

lonng commented Jan 16, 2019

/rebuild

@lonng lonng force-pushed the lonng/limit-closed-engine branch 2 times, most recently from b2847a0 to 160ec35 Compare January 16, 2019 12:41
@lonng
Copy link
Contributor Author

lonng commented Jan 16, 2019

/run-all-tests

1 similar comment
@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@lonng
Copy link
Contributor Author

lonng commented Jan 17, 2019

/run-all-tests

1 similar comment
@lonng
Copy link
Contributor Author

lonng commented Jan 18, 2019

/run-all-tests

@lonng lonng force-pushed the lonng/limit-closed-engine branch from 1ad16a0 to 25e320b Compare January 18, 2019 07:27
@lonng
Copy link
Contributor Author

lonng commented Jan 18, 2019

/run-all-tests

@lonng lonng force-pushed the lonng/limit-closed-engine branch from 8593709 to a973bb9 Compare January 18, 2019 08:15
@lonng
Copy link
Contributor Author

lonng commented Jan 18, 2019

/run-all-tests

@lonng lonng force-pushed the lonng/limit-closed-engine branch from a973bb9 to 4dda11b Compare January 18, 2019 08:20
@lonng lonng added status/PTAL This PR is ready for review. Add this label back after committing new changes priority/normal and removed status/DNM Do not merge, test is failing or blocked by another PR labels Jan 21, 2019
@lonng
Copy link
Contributor Author

lonng commented Jan 21, 2019

PTAL @kennytm @GregoryIan @july2993

@kennytm kennytm added type/feature New feature Should Update Docs Should update docs after this PR is merged. Remove this label once the docs are updated Should Update Ansible The config in TiDB-Ansible should be updated labels Jan 21, 2019
kennytm
kennytm reviewed Jan 21, 2019
View reviewed changes
lightning/restore/restore.go Outdated Show resolved Hide resolved
lightning/restore/restore.go Show resolved Hide resolved
@lonng
Copy link
Contributor Author

lonng commented Jan 21, 2019

/run-all-tests

@kennytm kennytm mentioned this pull request Feb 12, 2019
Merged
@kennytm
Copy link
Collaborator

kennytm commented Feb 12, 2019

@lonng Please sign the CLA.

kennytm
kennytm reviewed Feb 12, 2019
View reviewed changes
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

PTAL @GregoryIan @july2993, this PR is blocking tikv/tikv#4199.

tidb-lightning.toml Outdated Show resolved Hide resolved
@kennytm kennytm added status/LGT1 One reviewer already commented LGTM (LGTM1) and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Feb 12, 2019
@IANTHEREAL
Copy link
Collaborator

LGTM

@IANTHEREAL IANTHEREAL added status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) and removed status/LGT1 One reviewer already commented LGTM (LGTM1) labels Feb 13, 2019
@lonng lonng merged commit 10b9033 into master Feb 13, 2019
@lonng lonng deleted the lonng/limit-closed-engine branch February 13, 2019 03:38
@kennytm kennytm removed the Should Update Docs Should update docs after this PR is merged. Remove this label once the docs are updated label Apr 27, 2019
@kennytm kennytm mentioned this pull request Dec 24, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kennytm kennytm kennytm left review comments

Assignees
No one assigned
Labels
Should Update Ansible The config in TiDB-Ansible should be updated status/LGT2 Two reviewers already commented LGTM, ready for merge (LGTM2) type/feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lonng @sre-bot @zhouqiang-cl @kennytm @IANTHEREAL