Skip to content
This repository has been archived by the owner on Dec 8, 2021. It is now read-only.

restore: remove hack.String #112

Merged
merged 1 commit into from
Dec 26, 2018
Merged

restore: remove hack.String #112

merged 1 commit into from
Dec 26, 2018

Conversation

lonng
Copy link
Contributor

@lonng lonng commented Dec 25, 2018

What problem does this PR solve?

#108 (comment)

What is changed and how it works?

Check List

Tests

Code changes

Side effects

Related changes

@sre-bot
Copy link

sre-bot commented Dec 25, 2018

Hi contributor, thanks for your PR.

This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically.

@lonng lonng added status/PTAL This PR is ready for review. Add this label back after committing new changes priority/unimportant labels Dec 25, 2018
lightning/restore/restore.go Outdated Show resolved Hide resolved
lightning/restore/restore.go Outdated Show resolved Hide resolved
@lonng lonng force-pushed the lonng/remove-hack-string branch from fee19e7 to 531aa02 Compare December 26, 2018 02:53
Copy link
Collaborator

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kennytm kennytm added status/LGT1 One reviewer already commented LGTM (LGTM1) and removed status/PTAL This PR is ready for review. Add this label back after committing new changes labels Dec 26, 2018
@lonng lonng merged commit 232f7f4 into master Dec 26, 2018
@lonng lonng deleted the lonng/remove-hack-string branch December 26, 2018 06:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status/LGT1 One reviewer already commented LGTM (LGTM1)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants