-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable heap profiling #376
Enable heap profiling #376
Conversation
Signed-off-by: CalvinNeo <[email protected]>
Signed-off-by: CalvinNeo <[email protected]>
/retest |
&mut value as *mut _ as *mut _, | ||
&mut len, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should allocate another local value for storing the "old_value" get from mallctl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to "write" mode
Signed-off-by: CalvinNeo <[email protected]>
/retest |
1 similar comment
/retest |
Log
|
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JinheLin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
This reverts commit 87b6682.
This reverts commit 88ff7b3.
What is changed and how it works?
Issue Number: Close #xxx
What's Changed:
Note that TiKV no longer uses these APIs. They have switched to a continuous heap profiling.
We can switch later to that, after we are assured that the deadlock problem is resolved by the latest pprof-rs.
lg_prof_interval
, since it can't be modified at runtime.Related changes
pingcap/docs
/pingcap/docs-cn
:Check List
Tests
Side effects
Release note