Strengthen configuration change approval

[wuhuizuo]

Ref pingcap/tiflash#8966

What is changed and how it works?

Issue Number: Close #xxx

What's Changed:

Related changes

• Need to cherry-pick to the release branch

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Release note

None

[CLAassistant]

All committers have signed the CLA.

[wuhuizuo]

/run-unit-test

[wuhuizuo]

/test unit-test

[ti-chi-bot]

@wuhuizuo: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

• /test pull-unit-test

Use /test all to run all jobs.

In response to this:

/test unit-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wuhuizuo]

/test pull-unit-test

[wuhuizuo]

/cc @easonn7 @yudongusa @CalvinNeo @zanmato1984

[ti-chi-bot]

@wuhuizuo: GitHub didn't allow me to request PR reviews from the following users: yudongusa, zanmato1984, easonn7.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @easonn7 @yudongusa @CalvinNeo @zanmato1984

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[wuhuizuo]

I do not known why the build-check CI task failed.

[CalvinNeo]

@wuhuizuo If we merged tikv/master, which introduces some new configurations, do we also need to approve them here?

[CalvinNeo]

I do not known why the build-check CI task failed.

Because the free space provided by github is not enough

[wuhuizuo]

@wuhuizuo If we merged tikv/master, which introduces some new configurations, do we also need to approve them here?

@CalvinNeo Sorry for the late reply.

No, here we just controlled the config.rs in proxy_components/proxy_server/src folder, unless we also merged the OWNERS of the upstream repository, if so it will need the approvals from the tikv approvers.

Of course, there are additional benefits at this time: knowing important changes and understanding the related impacts with experts. The focus at this time is to understand the upstream changes rather than the approval process (which happens less frequently).

[wuhuizuo]

/hold

it should be merged by @wuhuizuo

[wuhuizuo]

Ref: ti-community-infra/configs#1067