Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release #1138

Merged
merged 5 commits into from
Jan 12, 2022
Merged

Fix release #1138

merged 5 commits into from
Jan 12, 2022

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Jan 12, 2022

What did:

  • Hide "diagnose" app, it's not GA yet
  • Rename "System Report" back to "Cluster Diagnostic"
  • Add metrics relationship graph feature back (added in PR Release v2020.09.21.1 #760 and not cherry-pick back to the master)
  • Disable control form if conprof is disabled

Screeshots:

image

image

image

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Jan 12, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • breeswish

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@baurine baurine requested a review from breezewish January 12, 2022 07:42
@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2022

Codecov Report

Merging #1138 (e300fd6) into master (28d36cd) will decrease coverage by 0.14%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1138      +/-   ##
==========================================
- Coverage   28.25%   28.10%   -0.15%     
==========================================
  Files         227      227              
  Lines       12841    12908      +67     
  Branches      647      647              
==========================================
  Hits         3628     3628              
- Misses       9063     9130      +67     
  Partials      150      150              
Flag Coverage Δ
be_integration_test_latest 6.88% <ø> (ø)
be_integration_test_v4.0.1 6.88% <ø> (ø)
be_unit_test 23.83% <0.00%> (-0.18%) ⬇️
e2e_test 46.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/apiserver/diagnose/diagnose.go 0.00% <0.00%> (ø)
ui/dashboardApp/layout/main/Sider/index.tsx 97.72% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28d36cd...e300fd6. Read the comment docs.

@baurine baurine merged commit ac4ddec into master Jan 12, 2022
@baurine baurine deleted the fix-release branch January 12, 2022 10:03
@baurine baurine restored the fix-release branch January 12, 2022 10:03
@baurine baurine deleted the fix-release branch January 12, 2022 10:03
baurine added a commit that referenced this pull request Jan 12, 2022
)

* add metrics relationship graph back

* hide diagnose app

* disable form is conprof is disabled

* revert i18n for system report app
baurine added a commit that referenced this pull request Jan 12, 2022
)

* add metrics relationship graph back

* hide diagnose app

* disable form is conprof is disabled

* revert i18n for system report app
baurine added a commit that referenced this pull request Jan 12, 2022
* tweak: create pd pr for 5.3, 5.4 branches (#1133)

* misc: update assert to require (#1135)

* hide diagnose and rename system report back to cluster diagnostic (#1138)

Co-authored-by: Suhaha <[email protected]>
Co-authored-by: Wenxuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants