Fix panic of empty value in filter config #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check not having empty value now
suzaku
reviewed
Nov 7, 2019
| re = regexp.MustCompile(fmt.Sprintf("(?i)%s", originStr[1:])) | ||
| } else { // must match completely | ||
| re = regexp.MustCompile(fmt.Sprintf("(?i)^%s$", originStr)) |
There was a problem hiding this comment.
If originStr is empty, the regex become ^$?
There was a problem hiding this comment.
yes, the else case means you must match totally.
but we check the config for empty schema and table at startup time, so it will not run into this case now actually, because it's meaningless for an empty schema and table, may cause by misconfiguring.
|
/run-all-tests |
|
cherry pick to release-3.1 in PR #800 |
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 in PR #801 |
july2993
added a commit
to july2993/tidb-binlog
that referenced
this pull request
Nov 11, 2019
Fix panic of empty value in filter config Verify config about filters with empty schema or table name.
july2993
added
already-cherry-pick-2.1
and removed
needs-cherry-pick-release-2.1
labels
sre-bot
added a commit
that referenced
this pull request
Nov 11, 2019
sre-bot
added a commit
that referenced
this pull request
Nov 12, 2019
july2993
added a commit
that referenced
this pull request
Nov 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix panic of empty value in filter config
Verify config about filters
What is changed and how it works?
Fix panic of empty value in filter config
Verify config about filters
Check List
Tests
Code changes
Side effects
Related changes
Need to cherry-pick to the release branch
Need to be included in the release note