*: Decouple Checkpoint type from dest-type (#786) #790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
after this pr: we have this checkpoint type: mysql/tidb, file, flash defalut using checkpoint type accroding to dest-type like before mysql/tidb -> mysql/tidb (the same downstream) flash -> flash kafka/file -> file and we can configure the checkpoint type despite what the dest-type is; currently only can configure the checkpoint type to be mysql/tidb
|
LGTM |
IANTHEREAL
approved these changes
Nov 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry-pick #786 to release-3.0
What problem does this PR solve?
*: Decouple Checkpoint type from dest-type
What is changed and how it works?
after this pr:
we have this checkpoint type: mysql/tidb, file, flash
defalut using checkpoint type accroding to dest-type like before
mysql/tidb -> mysql/tidb (the same downstream)
flash -> flash
kafka/file -> file
and we can configure the checkpoint type despite what the dest-type is;
currently only can configure the checkpoint type to be mysql/tidb
Check List
Tests
run dest-type = kafka and save checkpoint in db and check it manually.
Related changes