Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip the "cancled" ddl in ddl history (#1229) (#1230) #1255

Merged

Conversation

ti-chi-bot
Copy link
Member

@ti-chi-bot ti-chi-bot commented Jun 30, 2023

This is an automated cherry-pick of #1230

This is an automated cherry-pick of #1229

What problem does this PR solve?

Issue Number: close #1228

What is changed and how it works?

as title

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

Release note

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

@okJiang: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 30, 2023

@dsdashun: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@GMHDBJD GMHDBJD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot removed the lgtm label Jul 2, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 3, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dsdashun, GMHDBJD, lichunzhu, niubell, okJiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [GMHDBJD,dsdashun,lichunzhu,niubell,okJiang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 3, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-30 09:57:45.974798553 +0000 UTC m=+79549.349376404: ☑️ agreed by lichunzhu.
  • 2023-06-30 10:17:55.547388215 +0000 UTC m=+80758.921966051: ☑️ agreed by GMHDBJD.
  • 2023-07-02 07:45:19.402352261 +0000 UTC m=+244402.776930101: ✖️🔁 reset by lichunzhu.
  • 2023-07-02 11:10:58.184191253 +0000 UTC m=+256741.558769105: ☑️ agreed by lichunzhu.
  • 2023-07-03 02:01:30.035883185 +0000 UTC m=+48521.674682977: ☑️ agreed by niubell.

@ti-chi-bot ti-chi-bot bot merged commit 9f5e669 into pingcap:release-6.1 Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants