Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix drainer can't send request correctly to pump when set compressor=gzip (#1186) #1196

Merged
merged 3 commits into from
Aug 17, 2022
Merged

*: fix drainer can't send request correctly to pump when set compressor=gzip (#1186) #1196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
754911b
add compress test
lichunzhu Aug 16, 2022
585b704
fix compress
lichunzhu Aug 16, 2022
7409d9a
address comment
lichunzhu Aug 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion drainer/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ import (

const (
maxKafkaMsgSize = 1 << 30
maxGrpcMsgSize = int(^uint(0) >> 1)
// max grpc message size, leave 4MB as buffer. Because when grpc decompresses messages, it will leave a few buffer
// for this, which overflows the int64: https://github.com/grpc/grpc-go/blob/v1.44.0/rpc_util.go#L742
maxGrpcMsgSize = int(^uint(0)>>1) - 4*1024*1024
)

// taskGroup is a wrapper of `sync.WaitGroup`.
Expand Down
10 changes: 6 additions & 4 deletions pump/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,12 @@ import (
)

const (
defaultEtcdDialTimeout = 5 * time.Second
defaultEtcdURLs = "http://127.0.0.1:2379"
defaultListenAddr = "127.0.0.1:8250"
defaultMaxMsgSize = int(^uint(0) >> 1) // max grpc message size
defaultEtcdDialTimeout = 5 * time.Second
defaultEtcdURLs = "http://127.0.0.1:2379"
defaultListenAddr = "127.0.0.1:8250"
// max grpc message size, leave 4MB as buffer. Because when grpc decompresses messages, it will leave a few buffer
// for this, which overflows the int64: https://github.com/grpc/grpc-go/blob/v1.44.0/rpc_util.go#L742
defaultMaxMsgSize = int(^uint(0)>>1) - 4*1024*1024
defaultHeartbeatInterval = 2
defaultGC = "7"
defaultDataDir = "data.pump"
Expand Down
2 changes: 1 addition & 1 deletion tests/cache_table/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ set -e

cd "$(dirname "$0")"

run_drainer &
run_drainer --compressor gzip &

sleep 3

Expand Down