Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parser: parse the fraction of CURRENT_TIMESTAMP default value (#211) #565

Merged
merged 3 commits into from
Oct 14, 2019

Conversation

tangenta
Copy link
Contributor

Cherry-pick #211 and #214.

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason
Copy link
Member

@tangenta It's better to cherry pick the bug-fixes one by one. So that we can tell which PR is not cherry-picked to the release branch through the commit history in git logs.

@tangenta
Copy link
Contributor Author

@zz-jason These two PRs are filed to solve the same problem. Should I append (#214) to the end of the title?

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added status/LGT2 LGT2 and removed PTAL labels Oct 14, 2019
@tangenta tangenta merged commit e7801c9 into pingcap:release-2.1 Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants