ast, parser: extract create view parameters to CreateViewStmt

[AndrewDi]

As part of view feature implement, extract create view parameters to CreateViewStmt, ref pingcap#8416

[AndrewDi]

@XuHuaiyu PTAL

[XuHuaiyu]

@AndrewDi Please create an issue in tidb repo to trace the P1 tasks.

[XuHuaiyu]

Why not check Equals?

[XuHuaiyu]

Add check for viewName, colList, view_select_stmt?

[zz-jason]

how about defining a String() function for Algorithm:

func (a *Algorithm) String() string {
    switch *a {
        case AlgorithmUndefined:  return "UNDEFINED"
        case AlgorithmMerge    :  return "MERGE"
        case AlgorithmTemptable:  return "TEMPTABLE"
    }
    return "WRONG_ALGORITHM"
}

[zz-jason]

Here is the benchmark result:

[jianzhang.zj:/tmp]
➜ go test -bench Benchmark -run xx . -count 5
goos: darwin
goarch: amd64
BenchmarkString-8       2000000000               0.62 ns/op
BenchmarkString-8       2000000000               0.63 ns/op
BenchmarkString-8       2000000000               0.63 ns/op
BenchmarkString-8       2000000000               0.62 ns/op
BenchmarkString-8       2000000000               0.62 ns/op
BenchmarkMapAcess-8     500000000                3.75 ns/op
BenchmarkMapAcess-8     500000000                3.79 ns/op
BenchmarkMapAcess-8     500000000                3.75 ns/op
BenchmarkMapAcess-8     500000000                3.74 ns/op
BenchmarkMapAcess-8     500000000                3.75 ns/op
PASS
ok      _/tmp   17.924s

Here is the benchmark code:

package main

import "testing"

type Algorithm int

const (
    AlgorithmUndefined Algorithm = iota
    AlgorithmMerge
    AlgorithmTemptable
)

func (a *Algorithm) String() string {
    switch *a {
    case AlgorithmUndefined:
        return "UNDEFINED"
    case AlgorithmMerge:
        return "MERGE"
    case AlgorithmTemptable:
        return "TEMPTABLE"
    }
    return "WRONG_ALGORITHM"
}

var AlgorithmType = map[Algorithm]string{
    AlgorithmUndefined: "UNDEFINED",
    AlgorithmMerge:     "MERGE",
    AlgorithmTemptable: "TEMPTABLE",
}

func BenchmarkString(b *testing.B) {
    var a Algorithm = AlgorithmUndefined
    b.ResetTimer()
    for i := 0; i < b.N; i++ {
        a.String()
    }
}

func BenchmarkMapAcess(b *testing.B) {
    var a Algorithm = AlgorithmUndefined
    b.ResetTimer()
    for i := 0; i < b.N; i++ {
        _ = AlgorithmType[a]
    }
}

[zz-jason]

s/Algorithm/ViewAlgorithm/?

[zz-jason]

s/Security/ViewSecurity/

[zz-jason]

ditto

[zz-jason]

s/CheckOption/ViewCheckOption/

[zz-jason]

ditto

[zz-jason]

should we visit n.ddlNode?

[AndrewDi]

Currently ddlNode is not able to visit, and it only contains a statement string.

[zz-jason]

got it.

[XuHuaiyu]

move this line down out of the native packages

[XuHuaiyu]

Why do we TrimSpace here?
If there are redundant spaces, we need to change parser.y to extract the exact sql text.

[AndrewDi]

Just done yet...

[XuHuaiyu]

Add a . at the end of this comment.
So as the other comment lines if they are complete sentences.

[AndrewDi]

@XuHuaiyu @zz-jason PTAL

[XuHuaiyu]

I tested it locally. Seems we do not need this strings.TrimSpace.

[AndrewDi]

If I remove strings.TrimSpace, extra space would make test fail.

FAIL: parser_test.go:2220: testParserSuite.TestView

parser_test.go:2265:
    c.Assert(v.Select.Text(), Equals, "select c,d,e from t")
... obtained string = "" +
...     "select c,d,e from t \n" +
...     "                  "
... expected string = "select c,d,e from t"

[AndrewDi]

You can use sql string for test:

src := `CREATE OR REPLACE ALGORITHM = UNDEFINED DEFINER = root@localhost
                  SQL SECURITY DEFINER
			      VIEW V(a,b,c) AS select c,d,e from t 
                  WITH CASCADED CHECK OPTION;`

[XuHuaiyu]

LGTM
PTAL @zz-jason

[zz-jason]

LGTM