Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type/compatibility: fix show create table output of generated column #315

Merged
merged 1 commit into from
May 5, 2019

Conversation

bb7133
Copy link
Member

@bb7133 bb7133 commented May 5, 2019

Cherry-pick #235 to convert charset name to lower-case.

@bb7133 bb7133 changed the title type/compatibility: fix show create table output of generated column … type/compatibility: fix show create table output of generated column May 5, 2019
@bb7133
Copy link
Member Author

bb7133 commented May 5, 2019

PTAL @crazycs520 @winkyao @jackysp

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT1 LGT1 label May 5, 2019
Copy link
Contributor

@crazycs520 crazycs520 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao winkyao closed this May 5, 2019
@winkyao winkyao reopened this May 5, 2019
@winkyao winkyao merged commit 595d728 into pingcap:release-2.1 May 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants