Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suspend unknown collation id 255 error #294

Merged
merged 3 commits into from
Apr 18, 2019
Merged

suspend unknown collation id 255 error #294

merged 3 commits into from
Apr 18, 2019

Conversation

lysu
Copy link
Collaborator

@lysu lysu commented Apr 18, 2019

What problem does this PR solve?

fixes pingcap/tidb#9426

What is changed and how it works?

support 255 collation

Check List

Tests

  • Unit test

Code changes

  • N/A

Side effects

  • N/A

Related changes

  • N/A

This change is Reviewable

Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Apr 18, 2019

LGTM, please be attention that TiDB code should be updated.

@kennytm kennytm added the status/LGT2 LGT2 label Apr 18, 2019
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 merged commit 2cdba81 into pingcap:master Apr 18, 2019
@shenli
Copy link
Member

shenli commented Apr 18, 2019

Should we cherry-pick this to the release-2.1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for utf8mb4_0900_ai_ci in syntax.
5 participants