Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

charset: add type of NULL for charset #249

Closed
wants to merge 2 commits into from
Closed

charset: add type of NULL for charset #249

wants to merge 2 commits into from

Conversation

xiekeyi98
Copy link
Contributor

What problem does this PR solve?

Fix pingcap/tidb#9807
Relate PR: pingcap/tidb#9810

What is changed and how it works?

Add new field NULL.

Check List

Tests

  • Unit test
  • Integration test

@xiekeyi98 xiekeyi98 changed the title ddl:show full columns for date, datetime, timestamp compatibility. charset: add type of NULL for charset Mar 19, 2019
Copy link
Contributor

@kennytm kennytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

charset/charset.go Outdated Show resolved Hide resolved
@kennytm kennytm added the status/LGT1 LGT1 label Mar 20, 2019
@xiekeyi98
Copy link
Contributor Author

I will try another method to solve this issue.
Close this PR temporary.
Thanks♪(・ω・)ノ

@xiekeyi98 xiekeyi98 closed this Mar 20, 2019
@xiekeyi98 xiekeyi98 deleted the issue9807 branch April 1, 2019 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

compatibility: “show full columns” prints wrong Collation for date, datatime, timestamp columns
3 participants