*: clean up the deserted syntax of START TRANSACTION READ ONLY #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
|
@djshow832 @nolouch PTAL. |
|
/lgtm |
nolouch
reviewed
May 25, 2021
| Mode string | ||
| ReadOnly bool | ||
| Bound *TimestampBound | ||
| CausalConsistencyOnly bool |
There was a problem hiding this comment.
After checking the TiDB code, I think this is used. Maybe I shouldn't remove it.
There was a problem hiding this comment.
There was a problem hiding this comment.
@nolouch @youjiali1995 I added it back and added more test cases. PTAL.
…t_transaction_syntax
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
ti-srebot
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: JmPotato [email protected]
What problem does this PR solve?
Part of pingcap/tidb#24291 and pingcap/tidb#24813.
What is changed and how it works?
After supporting the
AS OF TIMESTAMPsyntax forSTART TRANSACTION READ ONLYstatement, we need to clean up the remaining deserted syntax.Check List
Tests