goyacc: fix unstable sorted yyXLAT output

When two strings have the same lowercase value, break-even by comparing case-sensitively.
pingcap · Nov 3, 2018 · 50457f2 · 50457f2
1 parent 7ec62ab
commit 50457f2
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 8 deletions.
diff --git a/goyacc/main.go b/goyacc/main.go
@@ -222,7 +222,15 @@ func (s symsUsed) Less(i, j int) bool {
 		return false
 	}
 
-	return strings.ToLower(s[i].sym.Name) < strings.ToLower(s[j].sym.Name)
+	caseFoldedCompare := strings.Compare(strings.ToLower(s[i].sym.Name), strings.ToLower(s[j].sym.Name))
+	if caseFoldedCompare < 0 {
+		return true
+	}
+	if caseFoldedCompare > 0 {
+		return false
+	}
+
+	return s[i].sym.Name < s[j].sym.Name
 }
 
 func main1(in string) (err error) {

diff --git a/parser.go b/parser.go