Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: upgrade to go1.23 #264

Merged
merged 3 commits into from
Oct 8, 2024
Merged

*: upgrade to go1.23 #264

merged 3 commits into from
Oct 8, 2024

Conversation

mornyx
Copy link
Collaborator

@mornyx mornyx commented Sep 20, 2024

What problem does this PR solve?

Issue Number: close #263

What is changed and how it works?

Upgrade to go1.23

Signed-off-by: mornyx <[email protected]>
Signed-off-by: mornyx <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/S and removed size/XS labels Sep 20, 2024
@purelind
Copy link
Contributor

/hold

Waiting for the test report to be completed.

@mornyx
Copy link
Collaborator Author

mornyx commented Oct 8, 2024

/uncc siddontang

@ti-chi-bot ti-chi-bot bot removed the request for review from siddontang October 8, 2024 02:34
@mornyx
Copy link
Collaborator Author

mornyx commented Oct 8, 2024

/cc @zhangpeijin-milo

Copy link

ti-chi-bot bot commented Oct 8, 2024

@mornyx: GitHub didn't allow me to request PR reviews from the following users: zhangpeijin-milo.

Note that only pingcap members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @zhangpeijin-milo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@purelind
Copy link
Contributor

purelind commented Oct 8, 2024

/lgtm

Copy link

ti-chi-bot bot commented Oct 8, 2024

@purelind: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 8, 2024
Copy link

ti-chi-bot bot commented Oct 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, purelind

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Oct 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-08 02:48:16.399386298 +0000 UTC m=+927851.819599310: ☑️ agreed by crazycs520.

@ti-chi-bot ti-chi-bot bot added the approved label Oct 8, 2024
@mornyx
Copy link
Collaborator Author

mornyx commented Oct 8, 2024

/unhold

@mornyx
Copy link
Collaborator Author

mornyx commented Oct 8, 2024

/merge

Copy link

ti-chi-bot bot commented Oct 8, 2024

@mornyx: We have migrated to builtin LGTM and approve plugins for reviewing.

👉 Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot merged commit 0c5bbdc into main Oct 8, 2024
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the mornyx/go branch October 8, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to go1.23
3 participants