Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: update golangci-lint version to fix ci #226

Merged
merged 1 commit into from
Dec 20, 2023
Merged

*: update golangci-lint version to fix ci #226

merged 1 commit into from
Dec 20, 2023

Conversation

mornyx
Copy link
Collaborator

@mornyx mornyx commented Dec 20, 2023

What problem does this PR solve?

Issue Number: close #225

What is changed and how it works?

  • Upgrade golangci-lint.
  • Little fixes on comments.

Copy link

@zhangpeijin-milo zhangpeijin-milo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link

ti-chi-bot bot commented Dec 20, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-20 08:49:00.726200351 +0000 UTC m=+1037231.763427269: ☑️ agreed by zhangpeijin-milo.

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 20, 2023
Copy link

ti-chi-bot bot commented Dec 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zhangpeijin-milo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 20, 2023
@ti-chi-bot ti-chi-bot bot merged commit 401c463 into main Dec 20, 2023
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the mornyx/ci branch December 20, 2023 08:49
@mornyx
Copy link
Collaborator Author

mornyx commented Dec 20, 2023

/cherry-pick release-7.5

@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-7.5: #228.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/ng-monitoring that referenced this pull request Dec 20, 2023
ti-chi-bot bot pushed a commit that referenced this pull request Dec 20, 2023
@mornyx
Copy link
Collaborator Author

mornyx commented Feb 28, 2024

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-7.1: #232.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@mornyx
Copy link
Collaborator Author

mornyx commented Feb 28, 2024

/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-6.5: #235.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failed on golangci-lint
3 participants