Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conprof: use debug=1 for goroutine profile to avoid STW #205

Merged
merged 3 commits into from
Dec 14, 2023
Merged

conprof: use debug=1 for goroutine profile to avoid STW #205

merged 3 commits into from
Dec 14, 2023

Conversation

djshow832
Copy link
Contributor

@djshow832 djshow832 commented Nov 25, 2023 •
edited by mornyx
Loading

What problem does this PR solve?

Issue Number: close #220

What is changed and how it works?

With debug=2, there are some huge STWs, which cause latency spikes in TiDB and PD.

@ti-chi-bot ti-chi-bot bot requested review from ngaut and qiuyesuifeng November 25, 2023 09:58
@ti-chi-bot ti-chi-bot bot added the size/XS label Nov 25, 2023
@mornyx
Copy link
Collaborator

mornyx commented Nov 27, 2023

/lgtm

@djshow832 djshow832 changed the title conprof: use debug=2 for goroutine profile to avoid STW conprof: use debug=1 for goroutine profile to avoid STW Nov 29, 2023
@mornyx
Copy link
Collaborator

mornyx commented Dec 14, 2023

/lgtm

@ti-chi-bot ti-chi-bot bot removed the lgtm label Dec 14, 2023
@mornyx
Copy link
Collaborator

mornyx commented Dec 14, 2023

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 14, 2023
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mornyx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 14, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-27 04:26:37.45366233 +0000 UTC m=+810426.118888526: ☑️ agreed by mornyx.
  • 2023-12-14 10:20:24.256535152 +0000 UTC m=+524315.293762079: ✖️🔁 reset by mornyx.
  • 2023-12-14 10:21:19.375327367 +0000 UTC m=+524370.412554305: ☑️ agreed by mornyx.

@ti-chi-bot ti-chi-bot bot merged commit 947befd into pingcap:main Dec 14, 2023
1 of 2 checks passed
@mornyx
Copy link
Collaborator

mornyx commented Dec 20, 2023

/cherry-pick release-7.5

@mornyx
Copy link
Collaborator

mornyx commented Dec 20, 2023

/cherry-pick release-7.1

@mornyx
Copy link
Collaborator

mornyx commented Dec 20, 2023

/cherry-pick release-6.5

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 20, 2023
Merged
@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-7.5: #221.

In response to this:

/cherry-pick release-7.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 20, 2023
Merged
@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-7.1: #222.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-6.5: #223.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 20, 2023
Merged
ti-chi-bot bot pushed a commit that referenced this pull request Dec 20, 2023
@ti-chi-bot
conprof: use debug=1 for goroutine profile to avoid STW (#205) (#223)
45a71f1 
close #220
ti-chi-bot bot pushed a commit that referenced this pull request Dec 20, 2023
@ti-chi-bot
conprof: use debug=1 for goroutine profile to avoid STW (#205) (#221)
317c9f9 
close #220
ti-chi-bot bot pushed a commit that referenced this pull request Dec 22, 2023
@ti-chi-bot
conprof: use debug=1 for goroutine profile to avoid STW (#205) (#222)
df75516 
close #220
@mornyx
Copy link
Collaborator

mornyx commented Jan 2, 2024

/cherry-pick release-6.1

@ti-chi-bot ti-chi-bot mentioned this pull request Jan 2, 2024
Merged
@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-6.1: #229.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot bot pushed a commit that referenced this pull request Jan 2, 2024
@ti-chi-bot
conprof: use debug=1 for goroutine profile to avoid STW (#205) (#229)
9e19070 
close #220
@djshow832 djshow832 deleted the goroutine_debug branch May 27, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngaut ngaut Awaiting requested review from ngaut

@qiuyesuifeng qiuyesuifeng Awaiting requested review from qiuyesuifeng

Assignees
No one assigned
Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change debug=2 to debug=1 on goroutine profiling
3 participants
@djshow832 @mornyx @ti-chi-bot