Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

conprof: disable profiling tiflash #184

Merged
merged 1 commit into from
Jun 7, 2023
Merged

conprof: disable profiling tiflash #184

merged 1 commit into from
Jun 7, 2023

Conversation

mornyx
Copy link
Collaborator

@mornyx mornyx commented Jun 7, 2023 •
edited
Loading

What problem does this PR solve?

Issue Number: close #185

What is changed and how it works?

Disable profiling TiFlash, again.

@ti-chi-bot ti-chi-bot bot requested review from c4pt0r and zhongzc June 7, 2023 05:47
@ti-chi-bot ti-chi-bot bot added the lgtm label Jun 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-07 05:56:56.438220385 +0000 UTC m=+70508.282854976: ☑️ agreed by zhongzc.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 7, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, zhongzc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: crazycs520, zhongzc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mornyx
Copy link
Collaborator Author

mornyx commented Jun 7, 2023

/merge

1 similar comment
@zhongzc
Copy link
Contributor

zhongzc commented Jun 7, 2023

/merge

@zhongzc zhongzc merged commit 0b36375 into pingcap:main Jun 7, 2023
@mornyx mornyx deleted the no-prof-tiflash branch June 7, 2023 06:07
@mornyx mornyx mentioned this pull request Jun 7, 2023
Closed
@mornyx
Copy link
Collaborator Author

mornyx commented Jun 7, 2023

/cherry-pick release-7.1

@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-7.1: #186.

In response to this:

/cherry-pick release-7.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 7, 2023
Merged
ti-chi-bot added a commit that referenced this pull request Jun 7, 2023
@ti-chi-bot
conprof: disable profiling tiflash (#184) (#186)
7893baa 
close #185
@mornyx
Copy link
Collaborator Author

mornyx commented Jun 7, 2023

/cherry-pick release-6.5

@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-6.5: #187.

In response to this:

/cherry-pick release-6.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 7, 2023
Merged
@mornyx
Copy link
Collaborator Author

mornyx commented Jun 7, 2023

/cherry-pick release-6.1

@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-6.1: #188.

In response to this:

/cherry-pick release-6.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jun 7, 2023
Merged
@mornyx
Copy link
Collaborator Author

mornyx commented Jun 7, 2023

/cherry-pick release-5.4

ti-chi-bot pushed a commit to ti-chi-bot/ng-monitoring that referenced this pull request Jun 7, 2023
@mornyx @ti-chi-bot
This is an automated cherry-pick of pingcap#184
f74e964 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 7, 2023
Closed
@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-5.4: #189.

In response to this:

/cherry-pick release-5.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@mornyx
Copy link
Collaborator Author

mornyx commented Jun 7, 2023

/cherry-pick release-5.3

@ti-chi-bot
Copy link
Member

@mornyx: new pull request created to branch release-5.3: #190.

In response to this:

/cherry-pick release-5.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot pushed a commit to ti-chi-bot/ng-monitoring that referenced this pull request Jun 7, 2023
@mornyx @ti-chi-bot
This is an automated cherry-pick of pingcap#184
5a388a3 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 7, 2023
Closed
ti-chi-bot bot pushed a commit that referenced this pull request Jun 9, 2023
@ti-chi-bot
conprof: disable profiling tiflash (#184) (#187)
e43f99c 
close #185
ti-chi-bot bot pushed a commit that referenced this pull request Jun 9, 2023
@ti-chi-bot
conprof: disable profiling tiflash (#184) (#188)
eb75b8c 
close #185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongzc zhongzc zhongzc approved these changes

@crazycs520 crazycs520 crazycs520 approved these changes

@c4pt0r c4pt0r Awaiting requested review from c4pt0r

Assignees
No one assigned
Labels
approved lgtm size/S status/can-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable profiling TiFlash
4 participants
@mornyx @zhongzc @ti-chi-bot @crazycs520