Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add reverse option in RawScanRequest and RawBatchScanRequest (#304) #434

Merged

Conversation

MyonKeminta
Copy link
Contributor

@MyonKeminta MyonKeminta commented Jul 29, 2019

This PR cherrypicks raw reverse scan to release-2.1. This is because pingcap/tidb#10152 needs to be cherry-picked to release-2.1, and it needs reverse querying functionality of region cache, which is provided in pingcap/tidb#8352 , and pingcap/tidb#8352 implements raw reverse scan and also needs end_key support for raw scan, which requires this thing in kvproto.

@MyonKeminta MyonKeminta changed the title add reverse option in RawScanRequest and RawBatchScanRequest (#304) Cherry-pick raw reverse scan and end_key support of raw scan(#304, #318) Jul 29, 2019
5kbpers
5kbpers previously approved these changes Jul 29, 2019
youjiali1995
youjiali1995 previously approved these changes Jul 30, 2019
AndreMouche
AndreMouche previously approved these changes Jul 30, 2019
@MyonKeminta MyonKeminta force-pushed the misono/reverse-raw-scan-2.1 branch from 9f66347 to b63af5f Compare July 30, 2019 03:22
@MyonKeminta MyonKeminta changed the title Cherry-pick raw reverse scan and end_key support of raw scan(#304, #318) add reverse option in RawScanRequest and RawBatchScanRequest (#304) Jul 30, 2019
@MyonKeminta
Copy link
Contributor Author

I excluded a commit and now this PR only cherry-picks one commit. PTAL again.

@MyonKeminta MyonKeminta dismissed stale reviews from AndreMouche, youjiali1995, and 5kbpers July 30, 2019 05:27

The code has changed. Please review again.

Copy link
Contributor

@5kbpers 5kbpers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MyonKeminta
Copy link
Contributor Author

@siddontang Could you help me merge it?

@siddontang siddontang merged commit 8be8979 into pingcap:release-2.1 Aug 1, 2019
@MyonKeminta MyonKeminta deleted the misono/reverse-raw-scan-2.1 branch August 1, 2019 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants