tpcc: add checkCondition6 and checkCondition11 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: mahjonp <[email protected]>
Signed-off-by: mahjonp <[email protected]>
|
condition11 is not work for mysql |
|
refer to TPC-C specification, we can know only condition check 1 - 4 must be demonstrated when running TPC-C. All of the checks must be met only after loading data. |
|
so we can separate into two checks - run check, and load check. |
Signed-off-by: mahjonp <[email protected]>
|
@siddontang PTAL |
siddontang
reviewed
Nov 15, 2019
| @@ -6,22 +6,34 @@ import ( | |||
| ) | |||
|
|
|||
| // Check implements Workloader interface | |||
| func (w *Workloader) Check(ctx context.Context, threadID int) error { | |||
| func (w *Workloader) Check(ctx context.Context, threadID int, checkForLoad bool) error { | |||
| // refer 3.3.2 | |||
| checks := []func(ctx context.Context, warehouse int) error{ | |||
| w.checkCondition1, | |||
| w.checkCondition2, | |||
| w.checkCondition3, | |||
| w.checkCondition4, | |||
There was a problem hiding this comment.
seem we still can check all in run except 11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add checkCondition6 and checkCondition11.
I found that checkCondition11 always failed after running tpcc run command for a while . PTAL @zhouqiang-cl
Signed-off-by: mahjonp [email protected]