errors: make errors.Trace mid-stack inlineable #12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go 1.12 with more aggressive inline strategy
https://tip.golang.org/doc/go1.12
so
error.Trace
can be inlined in 1.12, let nil check to Trace make less low level method callingwith default
-l
, go1.12 also can inline Trace,on another side in go1.11.3
and need -l=4 to make mid-stack inline, so this isn't work in version
< 1.12
this modification is very similar to https://go-review.googlesource.com/c/go/+/156362/
This change is