Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a typo in tidb-monitoring-api.md #6829

Merged
merged 3 commits into from
Nov 25, 2021
Merged

Fix a typo in tidb-monitoring-api.md #6829

merged 3 commits into from
Nov 25, 2021

Conversation

TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Nov 16, 2021 •
edited
Loading

What is changed, added or deleted? (Required)

Fix a typo in tidb-monitoring-api.md

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@TomShawn TomShawn added type/bugfix This PR fixes a bug. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-4.0 require-LGT1 Indicates that the PR requires an LGTM. area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. labels Nov 16, 2021
@TomShawn TomShawn requested a review from lilin90 November 16, 2021 11:28
@TomShawn TomShawn self-assigned this Nov 16, 2021
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 16, 2021 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • lilin90

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 16, 2021
@TomShawn TomShawn mentioned this pull request Nov 16, 2021
Merged
13 tasks
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 16, 2021
lilin90
lilin90 reviewed Nov 17, 2021
View reviewed changes
tidb-monitoring-api.md Outdated

- [The state interface](#running-status): this interface uses the HTTP interface to get the component information.
- [The status interface](#running-status): this interface uses the HTTP interface to get the component information.
- [Storage information](#storage-information): this interface uses the HTTP interface to get the storage information of data tables.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this one parallel with the other two? If yes, it would be better to use similar words such as "The xxx interface", and adjust the body heading level. Please help confirm. Thanks!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As confirmed with @xhebox, the storage information is subordinate to the status interface, together with the running status. Therefore, the storage information should not be in parallel with the status interface. PTAL. Thanks!

lilin90
lilin90 approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 19, 2021
@TomShawn
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 71e279d

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 25, 2021
@TomShawn TomShawn merged commit 1fd5ccf into master Nov 25, 2021
@TomShawn TomShawn deleted the TomShawn-patch-1 branch November 25, 2021 03:13
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 25, 2021
Merged
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6994.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6995.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 25, 2021
Merged
13 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 25, 2021
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#6829
9dac937 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 25, 2021
Closed
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6996.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 25, 2021
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#6829
dc438d2 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 25, 2021
Closed
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6997.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 25, 2021
@TomShawn @ti-chi-bot
This is an automated cherry-pick of pingcap#6829
e7126f0 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 25, 2021
Closed
13 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #6998.

ti-chi-bot added a commit that referenced this pull request Nov 25, 2021
@ti-chi-bot
Fix a typo in tidb-monitoring-api.md (#6829) (#6994)
61cb4e8
ti-chi-bot added a commit that referenced this pull request Nov 25, 2021
@ti-chi-bot
Fix a typo in tidb-monitoring-api.md (#6829) (#6995)
aea3e56
This was referenced Dec 7, 2021
Merged
Merged
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilin90 lilin90 lilin90 approved these changes

Assignees

@TomShawn TomShawn

Labels
area/diagnosis Indicates that the Issue or PR belongs to the area of diagnosis and monitoring. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TomShawn @ti-chi-bot @lilin90