Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

partitioning: Corrected partition management (#5498) #6026

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5498

Clarified currently supported partitioning management, and added experimental feature EXCHANGE PARTITION.
Fixes #5424

First-time contributors' checklist

What is changed, added or deleted? (Required)

Clarified currently supported partitioning management, and added experimental feature EXCHANGE PARTITION.
Fixes #5424
It mentioned split, merge and redefine, which is not clear what operations it refers to (REORGANIZE PARTITION, which is not supported)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

mjonss and others added 8 commits July 23, 2021 08:48
Clarified currently supported partitioning management, and added experimental feature EXCHANGE PARTITION.
Fixes pingcap#5424
According to TomShawn's suggestion, to better English.

Co-authored-by: TomShawn <[email protected]>
Better formatting for EXCHANGE PARTITION (not yet GA feature).

Co-authored-by: TomShawn <[email protected]>
@ti-chi-bot ti-chi-bot added first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR. labels Jul 23, 2021
@ti-chi-bot ti-chi-bot requested a review from TomShawn July 23, 2021 08:48
@ti-chi-bot
Copy link
Member Author

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 23, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member Author

This pull request has been accepted and is ready to merge.

Commit hash: 38f6bc1

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 23, 2021
@ti-chi-bot ti-chi-bot merged commit a29757c into pingcap:release-5.0 Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/cherry-pick-for-release-5.0 This PR is cherry-picked to release-5.0 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants