Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mention mysql replication #5422

Merged
merged 3 commits into from
Apr 26, 2021
Merged

mention mysql replication #5422

merged 3 commits into from
Apr 26, 2021

Conversation

Joyinqin
Copy link
Contributor

@Joyinqin Joyinqin commented Apr 21, 2021 •
edited
Loading

First-time contributors' checklist

What is changed, added or deleted? (Required)

Chinese part of #5137

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot requested a review from TomShawn April 21, 2021 09:04
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 21, 2021
@Joyinqin
Copy link
Contributor Author

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation from-doc-cn

@ti-chi-bot
Copy link
Member

@Joyinqin: The label(s) translation/from-doc-cn cannot be applied, because the repository doesn't have them.

In response to this:

/label needs-cherry-pick-5.0
/label needs-cherry-pick-4.0
/translation from-doc-cn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@Joyinqin
Copy link
Contributor Author

/translation from-docs-cn
/cc @lance6716

@ti-chi-bot ti-chi-bot requested a review from lance6716 April 21, 2021 09:05
@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed missing-translation-status This PR does not have translation status info. labels Apr 21, 2021
TomShawn
TomShawn reviewed Apr 22, 2021
View reviewed changes
mysql-compatibility.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

rest
/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 22, 2021
lance6716
lance6716 reviewed Apr 26, 2021
View reviewed changes
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm

mysql-compatibility.md Outdated
@@ -10,6 +10,10 @@ TiDB is fully compatible with the MySQL 5.7 protocol and the common features and

However, some features of MySQL are not supported. This could be because there is now a better way to solve the problem (such as XML functions superseded by JSON), or a lack of current demand versus effort required (such as stored procedures and functions). Some features might also be difficult to implement as a distributed system.

- In addition, TiDB does not support the MySQL replication protocol, but provides specific tools to replicate data with MySQL.
- Replicate data from MySQL: [TiDB Data Migration (DM)](https://docs.pingcap.com/tidb-data-migration/stable/overview) is a tool for migrating data from MySQL/MariaDB into TiDB and replicating the incremental data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Replicate data from MySQL: [TiDB Data Migration (DM)](https://docs.pingcap.com/tidb-data-migration/stable/overview) is a tool for migrating data from MySQL/MariaDB into TiDB and replicating the incremental data.
- Replicate data from MySQL: [TiDB Data Migration (DM)](https://docs.pingcap.com/tidb-data-migration/stable/overview) is a tool for migrating data from MySQL/MariaDB into TiDB and supports replicating the incremental data.

seems strange if migrating data and replicating the incremental data are in same level

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • lance6716

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 26, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 63d75f7

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 26, 2021
@ti-chi-bot ti-chi-bot merged commit a8dbfea into pingcap:master Apr 26, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 26, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5422 to release-4.0
91ae7e1 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5501

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 26, 2021
@Joyinqin @ti-srebot
cherry pick pingcap#5422 to release-5.0
3b79f32 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 26, 2021
Merged
11 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5502

ti-chi-bot pushed a commit that referenced this pull request Apr 26, 2021
@ti-srebot
mention mysql replication (#5422) (#5501)
a6cd3cc
ti-chi-bot pushed a commit that referenced this pull request Apr 26, 2021
@ti-srebot
mention mysql replication (#5422) (#5502)
47aed8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@lance6716 lance6716 lance6716 approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Joyinqin @ti-chi-bot @TomShawn @ti-srebot @lance6716