Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiup: add documents of publish, grant, and genkey #5184

Merged
merged 6 commits into from
Apr 9, 2021
Merged

tiup: add documents of publish, grant, and genkey #5184

merged 6 commits into from
Apr 9, 2021

Conversation

CharLotteiu
Copy link
Contributor

What is changed, added or deleted? (Required)

Add three TiUP reference docs.

  • tiup/tiup-command-mirror-publish.md
  • tiup/tiup-command-mirror-clone.md
  • tiup/tiup-command-mirror-genkey.md

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 1, 2021
@CharLotteiu
Copy link
Contributor Author

/label needs-cherry-pick-4.0
/label needs-cherry-pick-5.0
/translation from-docs-cn
/status PTAL
/cc @lucklove @TomShawn

@ti-chi-bot ti-chi-bot requested review from lucklove and TomShawn April 1, 2021 07:22
@ti-chi-bot ti-chi-bot added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 and removed missing-translation-status This PR does not have translation status info. labels Apr 1, 2021
@CharLotteiu
Copy link
Contributor Author

/rebase

lucklove
lucklove reviewed Apr 2, 2021
View reviewed changes
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tiup/tiup-command-mirror-grant.md Outdated Show resolved Hide resolved
tiup/tiup-command-mirror-grant.md Outdated Show resolved Hide resolved
TomShawn
TomShawn reviewed Apr 6, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments

tiup/tiup-command-mirror-genkey.md Outdated Show resolved Hide resolved
tiup/tiup-command-mirror-genkey.md Outdated Show resolved Hide resolved
tiup/tiup-command-mirror-grant.md Outdated Show resolved Hide resolved
tiup/tiup-command-mirror-grant.md Outdated Show resolved Hide resolved
tiup/tiup-command-mirror-grant.md Outdated Show resolved Hide resolved
tiup/tiup-command-mirror-publish.md Outdated Show resolved Hide resolved
tiup/tiup-command-mirror-publish.md Outdated Show resolved Hide resolved
tiup/tiup-command-mirror-publish.md Outdated Show resolved Hide resolved
@TomShawn
Copy link
Contributor

TomShawn commented Apr 6, 2021

/status require-change
/remove-status PTAL

@ti-chi-bot ti-chi-bot added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Apr 6, 2021
@ti-srebot
Copy link
Contributor

@CharLotteiu, please update your pull request.

@Joyinqin
Copy link
Contributor

Joyinqin commented Apr 9, 2021 •
edited
Loading

@lucklove @TomShawn PTAL again, thx~

@TomShawn
Copy link
Contributor

TomShawn commented Apr 9, 2021

/remove-status require-change
/label require-LGT1
/lgtm

@ti-chi-bot ti-chi-bot added require-LGT1 Indicates that the PR requires an LGTM. and removed status/require-change Needs the author to address comments. labels Apr 9, 2021
@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 9, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Apr 9, 2021

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 5f84417

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Apr 9, 2021
@ti-chi-bot ti-chi-bot merged commit 62b0414 into pingcap:master Apr 9, 2021
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 9, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5184 to release-4.0
91014c3 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 9, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #5273

ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Apr 9, 2021
@CharLotteiu @ti-srebot
cherry pick pingcap#5184 to release-5.0
2b2dd31 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Apr 9, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #5274

ti-chi-bot pushed a commit that referenced this pull request Apr 9, 2021
@ti-srebot
tiup: add documents of publish, grant, and genkey (#5184) (#5273)
e8d7686
ti-chi-bot pushed a commit that referenced this pull request Apr 9, 2021
@ti-srebot
tiup: add documents of publish, grant, and genkey (#5184) (#5274)
68c4620
@CharLotteiu CharLotteiu deleted the tiup-docs-2 branch July 9, 2021 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn left review comments

@lucklove lucklove lucklove left review comments

Assignees
No one assigned
Labels
require-LGT1 Indicates that the PR requires an LGTM. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@CharLotteiu @TomShawn @ti-srebot @Joyinqin @ti-chi-bot @lucklove