Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compatibility for temporary tables in dev #4935

Merged
merged 5 commits into from
Mar 4, 2021
Merged

Update compatibility for temporary tables in dev #4935

merged 5 commits into from
Mar 4, 2021

Conversation

nayuta-yanagisawa
Copy link
Contributor

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-srebot ti-srebot added the first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. label Feb 27, 2021
@nayuta-yanagisawa nayuta-yanagisawa mentioned this pull request Feb 27, 2021
Merged
@nayuta-yanagisawa nayuta-yanagisawa force-pushed the issue-22860 branch 2 times, most recently from 8960468 to 9fdd885 Compare February 28, 2021 18:32
@TomShawn TomShawn requested a review from morgo March 1, 2021 02:19
@morgo
Copy link
Contributor

morgo commented Mar 1, 2021

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Mar 1, 2021
@TomShawn TomShawn added size/small Changes of a small size. translation/doing This PR's assignee is translating this PR. labels Mar 1, 2021
TomShawn
TomShawn approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Mar 4, 2021
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Mar 4, 2021
@TomShawn TomShawn changed the title Update doc according to pingcap/tidb#22860 Update compatibility for temporary tables in dev Mar 4, 2021
@TomShawn TomShawn merged commit 20ac488 into pingcap:master Mar 4, 2021
@TomShawn
Copy link
Contributor

TomShawn commented Mar 4, 2021

@morgo Do other release branches need this change?

@nayuta-yanagisawa nayuta-yanagisawa deleted the issue-22860 branch March 4, 2021 12:15
@morgo
Copy link
Contributor

morgo commented Mar 4, 2021

Not currently. It is considered a compatibility-breaker, so it is not cherry picked.

@Joyinqin Joyinqin mentioned this pull request Mar 5, 2021
Merged
11 tasks
@Joyinqin
Copy link
Contributor

Joyinqin commented Mar 5, 2021

/label translation/done

@ti-srebot ti-srebot added the translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. label Mar 5, 2021
@Joyinqin
Copy link
Contributor

Joyinqin commented Mar 5, 2021

/unlabel translation/doing

@ti-srebot ti-srebot removed the translation/doing This PR's assignee is translating this PR. label Mar 5, 2021
@TomShawn
Copy link
Contributor

/label follow-up

@ti-chi-bot ti-chi-bot added the requires-followup This PR requires a follow-up task after being merged. label Mar 15, 2021
@TomShawn
Copy link
Contributor

See pingcap/docs-cn#5673 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ti-srebot ti-srebot ti-srebot approved these changes

@TomShawn TomShawn TomShawn approved these changes

@morgo morgo Awaiting requested review from morgo

Assignees

@Joyinqin Joyinqin

Labels
first-time-contributor Indicates that the PR was contributed by an external member and is a first-time contributor. requires-followup This PR requires a follow-up task after being merged. size/small Changes of a small size. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nayuta-yanagisawa @morgo @TomShawn @Joyinqin @ti-srebot @ti-chi-bot