Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiflash: Update tiflash note of importing data by Lightning #4516

Merged
merged 6 commits into from
Jan 4, 2021
Merged

tiflash: Update tiflash note of importing data by Lightning #4516

merged 6 commits into from
Jan 4, 2021

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Dec 29, 2020 •
edited
Loading

Signed-off-by: JaySon-Huang [email protected]

First-time contributors' checklist

What is changed, added or deleted? (Required)

Update tiflash note about importing data by Lightning. Users can create TiFlash replica before importing data by using TiDB Lightning since v4.0.6

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@JaySon-Huang
update tiflash notes
0cf18fa 
Signed-off-by: JaySon-Huang <[email protected]>
@JaySon-Huang JaySon-Huang mentioned this pull request Dec 29, 2020
Merged
10 tasks
@JaySon-Huang
Copy link
Contributor Author

@cyliu0 @zanmato1984 PTAL

@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Dec 29, 2020
cyliu0
cyliu0 approved these changes Dec 30, 2020
View reviewed changes
Copy link

@cyliu0 cyliu0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@cyliu0, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: docs(slack).

TomShawn
TomShawn reviewed Dec 31, 2020
View reviewed changes
tiflash/use-tiflash.md Outdated Show resolved Hide resolved
tiflash/use-tiflash.md Outdated Show resolved Hide resolved
@ti-srebot
Copy link
Contributor

@cyliu0, @zanmato1984, PTAL.

JaySon-Huang
JaySon-Huang commented Jan 4, 2021
View reviewed changes
tiflash/use-tiflash.md Outdated Show resolved Hide resolved
@JaySon-Huang
Copy link
Contributor Author

I've changed some wording for both the Chinese and English version. PTAL again @TomShawn

TomShawn
TomShawn reviewed Jan 4, 2021
View reviewed changes
tiflash/use-tiflash.md Outdated Show resolved Hide resolved
TomShawn
TomShawn approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jan 4, 2021
@TomShawn TomShawn merged commit 600de87 into pingcap:master Jan 4, 2021
@ti-srebot ti-srebot mentioned this pull request Jan 4, 2021
Merged
10 tasks
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jan 4, 2021
@JaySon-Huang @ti-srebot
cherry pick pingcap#4516 to release-4.0
5897444 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jan 4, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4568

@ti-srebot ti-srebot mentioned this pull request Jan 4, 2021
Merged
10 tasks
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Jan 4, 2021
@JaySon-Huang @ti-srebot
cherry pick pingcap#4516 to release-5.0
133f298 
Signed-off-by: ti-srebot <[email protected]>
@ti-srebot ti-srebot mentioned this pull request Jan 4, 2021
Merged
10 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-5.0 in PR #4569

TomShawn pushed a commit that referenced this pull request Jan 4, 2021
@ti-srebot @JaySon-Huang
cherry pick #4516 to release-5.0 (#4569)
3e0453a 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: JaySon <[email protected]>
TomShawn pushed a commit that referenced this pull request Jan 4, 2021
@ti-srebot @JaySon-Huang
cherry pick #4516 to release-4.0 (#4568)
edb15fd 
Signed-off-by: ti-srebot <[email protected]>

Co-authored-by: JaySon <[email protected]>
@JaySon-Huang JaySon-Huang deleted the update_tiflash_notes branch January 4, 2021 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomShawn TomShawn TomShawn approved these changes

@cyliu0 cyliu0 cyliu0 approved these changes

@zanmato1984 zanmato1984 Awaiting requested review from zanmato1984

Assignees
No one assigned
Labels
size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Users could create tiflash replicas before importing data w/ lightning
4 participants
@JaySon-Huang @ti-srebot @cyliu0 @TomShawn