Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update encryption and compression functions #17714

Merged
merged 17 commits into from
Jul 17, 2024
Merged

Update encryption and compression functions #17714

merged 17 commits into from
Jul 17, 2024

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented May 31, 2024

What is changed, added or deleted? (Required)

  1. Update the reference for the PASSWORD() function, which has been removed from MySQL 8.0 docs.

Might add more updates later

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from Oreoxmt and qiancai May 31, 2024 13:45
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 31, 2024
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 1, 2024
@dveeden dveeden requested a review from mjonss June 2, 2024 19:37
mjonss
mjonss approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor suggestions

functions-and-operators/encryption-and-compression-functions.md Outdated Show resolved Hide resolved
functions-and-operators/encryption-and-compression-functions.md Outdated Show resolved Hide resolved
functions-and-operators/encryption-and-compression-functions.md Outdated Show resolved Hide resolved
functions-and-operators/encryption-and-compression-functions.md Show resolved Hide resolved
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 3, 2024

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM, with some minor suggestions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden dveeden requested a review from hfxsd July 12, 2024 08:19
@hfxsd hfxsd added translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 and removed missing-translation-status This PR does not have translation status info. labels Jul 15, 2024
@Oreoxmt Oreoxmt removed request for hfxsd and qiancai July 15, 2024 07:46
@Oreoxmt Oreoxmt self-assigned this Jul 15, 2024
@Oreoxmt Oreoxmt added the type/enhancement The issue or PR belongs to an enhancement. label Jul 15, 2024
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 15, 2024
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 16, 2024
@Oreoxmt Oreoxmt requested a review from hfxsd July 16, 2024 07:54
@Oreoxmt Oreoxmt mentioned this pull request Jul 16, 2024
Merged
17 tasks
@Oreoxmt Oreoxmt added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jul 16, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 16, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 16, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-16 05:42:20.615355289 +0000 UTC m=+332562.606296759: ☑️ agreed by Oreoxmt.
  • 2024-07-16 11:44:21.599690421 +0000 UTC m=+354283.590631890: ☑️ agreed by hfxsd.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jul 17, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 17, 2024
@ti-chi-bot ti-chi-bot bot merged commit 86e856e into pingcap:master Jul 17, 2024
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18265.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 17, 2024
@dveeden @ti-chi-bot
This is an automated cherry-pick of pingcap#17714
e5a8c63 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jul 17, 2024
Merged
17 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #18266.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 17, 2024
@dveeden @ti-chi-bot
Update encryption and compression functions (pingcap#17714)
d605d33
This was referenced Jul 17, 2024
Merged
Merged
Merged
Oreoxmt pushed a commit to ti-chi-bot/docs that referenced this pull request Jul 17, 2024
@dveeden @Oreoxmt
Update encryption and compression functions (pingcap#17714)
638e33e
ti-chi-bot bot pushed a commit that referenced this pull request Jul 17, 2024
@ti-chi-bot
Update encryption and compression functions (#17714) (#18266)
c77dac6
ti-chi-bot bot pushed a commit that referenced this pull request Jul 17, 2024
@ti-chi-bot
Update encryption and compression functions (#17714) (#18265)
ff6f2ec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oreoxmt Oreoxmt Oreoxmt approved these changes

@hfxsd hfxsd hfxsd approved these changes

@mjonss mjonss mjonss approved these changes

Assignees

@Oreoxmt Oreoxmt

Labels
approved lgtm needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dveeden @Oreoxmt @ti-chi-bot @mjonss @hfxsd