Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud: enabling ttl table in serverless #17676

Merged

Conversation

baiyuqing
Copy link
Contributor

@baiyuqing baiyuqing commented May 30, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2024
Signed-off-by: baiyuqing <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 30, 2024
@Oreoxmt Oreoxmt added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. labels May 31, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 31, 2024
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented May 31, 2024

@baiyuqing Could you please invite a tech reviewer? Thanks!

github-actions bot pushed a commit to Oreoxmt/pingcap-docsite-preview that referenced this pull request May 31, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 31, 2024
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Oreoxmt Oreoxmt self-assigned this May 31, 2024
@baiyuqing baiyuqing changed the title cloud: enabling ttl table in serverless [DNM] cloud: enabling ttl table in serverless May 31, 2024
@Oreoxmt Oreoxmt added for-cloud-release This PR is related to TiDB Cloud release. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 31, 2024
@hfxsd hfxsd self-requested a review May 31, 2024 06:20
Signed-off-by: baiyuqing <[email protected]>
@baiyuqing baiyuqing requested a review from sunxiaoguang June 1, 2024 01:35
@baiyuqing baiyuqing changed the title [DNM] cloud: enabling ttl table in serverless cloud: enabling ttl table in serverless Jun 3, 2024
@Oreoxmt Oreoxmt removed the request for review from hfxsd June 3, 2024 02:07
Signed-off-by: baiyuqing <[email protected]>
Copy link

ti-chi-bot bot commented Jun 3, 2024

@ystaticy: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: baiyuqing <[email protected]>
Copy link

ti-chi-bot bot commented Jun 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-31 03:00:49.338989773 +0000 UTC m=+3004603.096125342: ☑️ agreed by Oreoxmt.
  • 2024-06-03 07:40:15.172864894 +0000 UTC m=+3280568.930000467: ☑️ agreed by qiancai.

Signed-off-by: baiyuqing <[email protected]>
mysql-schema.md Outdated Show resolved Hide resolved
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 5, 2024

/unhold
/approve

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2024
Copy link

ti-chi-bot bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #17769.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants