Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TiDB Cloud Docs: Add documentation for new Recovery Group feature #17425

Merged
merged 16 commits into from
Jun 5, 2024
Merged

TiDB Cloud Docs: Add documentation for new Recovery Group feature #17425

merged 16 commits into from
Jun 5, 2024

Conversation

benmeadowcroft
Copy link
Collaborator

@benmeadowcroft benmeadowcroft commented May 8, 2024 •
edited by hfxsd
Loading

What is changed, added or deleted? (Required)

Recovery Groups are a new feature for TiDB Cloud, this PR contains initial documentation for this feature for review by the docs team.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

benmeadowcroft and others added 2 commits April 23, 2024 17:28
@benmeadowcroft
TiDB Cloud: Add docs for new Recovery Group feature
d94f23f 
This is a new feature that requires documentation to explain the core concepts to users.

Signed-off-by: Ben Meadowcroft <[email protected]>
@benmeadowcroft
Merge branch 'pingcap:master' into recovery-group-documentation
9f95cc6
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 8, 2024
@benmeadowcroft
Changes to address review comments
da21f75 
Signed-off-by: Ben Meadowcroft <[email protected]>
@hfxsd hfxsd self-assigned this May 15, 2024
@hfxsd hfxsd added the translation/no-need No need to translate this PR. label May 15, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label May 15, 2024
@hfxsd hfxsd added the needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. label May 15, 2024
@hfxsd hfxsd self-requested a review May 15, 2024 08:52
@benmeadowcroft
Fixed incorrect terminology
ccf01e2 
Signed-off-by: Ben Meadowcroft <[email protected]>
hfxsd
hfxsd reviewed May 21, 2024
View reviewed changes
tidb-cloud/recovery-group-delete.md Outdated Show resolved Hide resolved
tidb-cloud/recovery-group-delete.md Outdated Show resolved Hide resolved
tidb-cloud/recovery-group-delete.md Outdated Show resolved Hide resolved
TOC-tidb-cloud.md Outdated Show resolved Hide resolved
tidb-cloud/recovery-group-delete.md Outdated Show resolved Hide resolved
tidb-cloud/recovery-group-failover.md Outdated Show resolved Hide resolved
tidb-cloud/recovery-group-failover.md Outdated Show resolved Hide resolved
tidb-cloud/recovery-group-get-started.md Outdated Show resolved Hide resolved
tidb-cloud/recovery-group-get-started.md Outdated Show resolved Hide resolved
tidb-cloud/recovery-group-get-started.md Outdated Show resolved Hide resolved
@hfxsd hfxsd requested a review from qiancai May 22, 2024 08:31
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 23, 2024
qiancai
qiancai approved these changes May 23, 2024
View reviewed changes
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

tidb-cloud/recovery-group-get-started.md Outdated Show resolved Hide resolved
tidb-cloud/recovery-group-delete.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 23, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 23, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-23 07:09:17.006398935 +0000 UTC m=+2328310.763534506: ☑️ agreed by hfxsd.
  • 2024-05-23 07:31:04.640999069 +0000 UTC m=+2329618.398134641: ☑️ agreed by qiancai.

@benmeadowcroft
Apply suggestion from code review
4eb89d9 
Signed-off-by: Ben Meadowcroft <[email protected]>
@benmeadowcroft
Addressing review comments
6bd256f 
Signed-off-by: Ben Meadowcroft <[email protected]>
@Oreoxmt Oreoxmt added the for-cloud-release This PR is related to TiDB Cloud release. label Jun 4, 2024
qiancai
qiancai approved these changes Jun 5, 2024
View reviewed changes
tidb-cloud/recovery-group-get-started.md Outdated Show resolved Hide resolved
tidb-cloud/recovery-group-get-started.md Outdated Show resolved Hide resolved
tidb-cloud/recovery-group-get-started.md Outdated Show resolved Hide resolved
tidb-cloud/recovery-group-get-started.md Outdated Show resolved Hide resolved
@hfxsd
Copy link
Collaborator

hfxsd commented Jun 5, 2024

/approve

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jun 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit 00dac2b into pingcap:master Jun 5, 2024
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.5: #17770.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Jun 5, 2024
@benmeadowcroft @ti-chi-bot
This is an automated cherry-pick of pingcap#17425
8d9b299 
Signed-off-by: ti-chi-bot <[email protected]>
@ti-chi-bot ti-chi-bot mentioned this pull request Jun 5, 2024
Merged
16 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Jun 5, 2024
@ti-chi-bot
TiDB Cloud Docs: Add documentation for new Recovery Group feature (#1…
fd47041 
…7425) (#17770)
@benmeadowcroft benmeadowcroft deleted the recovery-group-documentation branch June 5, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfxsd hfxsd hfxsd approved these changes

@grovecai grovecai grovecai approved these changes

@qiancai qiancai qiancai approved these changes

Assignees

@hfxsd hfxsd

Labels
approved area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. lgtm needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@benmeadowcroft @hfxsd @ti-chi-bot @grovecai @qiancai @Oreoxmt