Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/tidb-lightning: document backend and that system DBs are filtered #1620

Merged
merged 15 commits into from
Nov 15, 2019
Merged

tools/tidb-lightning: document backend and that system DBs are filtered #1620

merged 15 commits into from
Nov 15, 2019

Conversation

kennytm
Copy link
Contributor

@kennytm kennytm commented Oct 30, 2019 •
edited by lilin90
Loading

What is changed, added or deleted?

  • Add document changes introduced in TiDB Lightning v3.0.5.
  • Update the download links of Lightning to the latest version.
  • Add a doc for TiDB Lightning "TiDB" Back End.

What is the related PR or file link(s)?

Which version does your change affect?

v3.0, v3.1, dev

@kennytm kennytm force-pushed the kennytm/lighting-2019-11 branch from c3fba7a to 332911c Compare October 30, 2019 18:00
@kennytm kennytm requested a review from WangXiangUSTC October 31, 2019 06:27
WangXiangUSTC
WangXiangUSTC reviewed Nov 1, 2019
View reviewed changes
Copy link
Contributor

@WangXiangUSTC WangXiangUSTC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest LGTM

dev/reference/tools/tidb-lightning/backend.md Outdated Show resolved Hide resolved
@IANTHEREAL
Copy link
Contributor

LGTM

@IANTHEREAL
Copy link
Contributor

@lilin90 please test it using queeny testing

lilin90
lilin90 reviewed Nov 4, 2019
View reviewed changes
dev/reference/tools/tidb-lightning/backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/backend.md Outdated Show resolved Hide resolved
@lilin90 lilin90 added the translation/doing This PR's assignee is translating this PR. label Nov 4, 2019
@lilin90
Copy link
Member

lilin90 commented Nov 4, 2019

@lilin90 please test it using queeny testing

We'll do a test when this PR is ready.

@kennytm
Copy link
Contributor Author

kennytm commented Nov 10, 2019

@lilin90 sorry for late reply. All suggestions are applied.

lilin90
lilin90 reviewed Nov 11, 2019
View reviewed changes
dev/reference/tools/tidb-lightning/config.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/deployment.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/overview.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/table-filter.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/tidb_backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/tidb_backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/tidb_backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/tidb_backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/tidb_backend.md Outdated Show resolved Hide resolved
dev/reference/tools/tidb-lightning/tidb_backend.md Outdated Show resolved Hide resolved
@kennytm kennytm force-pushed the kennytm/lighting-2019-11 branch from 5a6bcb0 to 81071ab Compare November 11, 2019 09:50
lilin90
lilin90 approved these changes Nov 11, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90
Copy link
Member

lilin90 commented Nov 11, 2019 •
edited
Loading

@kennytm I think we also need to apply these changes to v3.1 (added last weekend).

@kennytm
Copy link
Contributor Author

kennytm commented Nov 13, 2019

Incorporated changes into v3.1.

lilin90
lilin90 approved these changes Nov 15, 2019
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilin90 lilin90 merged commit 2d7b5f0 into master Nov 15, 2019
@kennytm kennytm deleted the kennytm/lighting-2019-11 branch November 15, 2019 06:12
@anotherrachel anotherrachel mentioned this pull request Jan 14, 2020
Merged
@anotherrachel anotherrachel added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jan 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IANTHEREAL IANTHEREAL IANTHEREAL left review comments

@WangXiangUSTC WangXiangUSTC WangXiangUSTC left review comments

@lilin90 lilin90 lilin90 approved these changes

Assignees

@anotherrachel anotherrachel

Labels
translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kennytm @IANTHEREAL @lilin90 @WangXiangUSTC @anotherrachel @junlan-zhang