Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use support.md instead of direct links to GitHub #14648

Merged
merged 10 commits into from
Sep 6, 2023

Conversation

dveeden
Copy link
Contributor

@dveeden dveeden commented Aug 30, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

This is a response to https://github.com/pingcap/docs/pull/13375/files#r1308409173

We do still want users to report issues on GitHub, but for questions we have Slack/Discourse/etc and for bugs we want TiDB Enterprise and TiDB Cloud users to create a support ticket as well.

And for some services we have moved from Zendesk to Jira ServiceDesk.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from ran-huang and Oreoxmt August 30, 2023 07:40
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 30, 2023
@dveeden
Copy link
Contributor Author

dveeden commented Aug 30, 2023

cc @CocaLi

@dveeden dveeden mentioned this pull request Aug 30, 2023
15 tasks
dr-secondary-cluster.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-load-data.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-rename-user.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-show-create-database.md Outdated Show resolved Hide resolved
sql-statements/sql-statement-shutdown.md Outdated Show resolved Hide resolved
support.md Outdated Show resolved Hide resolved
troubleshoot-tidb-cluster.md Outdated Show resolved Hide resolved
troubleshoot-tidb-cluster.md Outdated Show resolved Hide resolved
troubleshoot-tidb-cluster.md Outdated Show resolved Hide resolved
support.md Outdated Show resolved Hide resolved
@dveeden
Copy link
Contributor Author

dveeden commented Sep 4, 2023

@ran-huang @Oreoxmt PTAL

@ran-huang
Copy link
Contributor

@dveeden I changed all /support.md to https://docs.pingcap.com/tidb/stable/support on purpose because /support.md doesn't exist in TiDB Cloud documentation. When an SQL statement doc is reused in TiDB Cloud TOC, the link of /support.md leads the users to nowhere (and the ci/tidb-cloud-check will report an error for this).

@dveeden
Copy link
Contributor Author

dveeden commented Sep 6, 2023

@ran-huang ah ok. I've removed my last change. Should be good now.

Copy link
Collaborator

@Oreoxmt Oreoxmt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

support.md Outdated Show resolved Hide resolved
support.md Outdated Show resolved Hide resolved
support.md Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 6, 2023
@ran-huang
Copy link
Contributor

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Sep 6, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 6, 2023
@ti-chi-bot ti-chi-bot bot merged commit 6d2a7ad into pingcap:master Sep 6, 2023
6 checks passed
@ran-huang ran-huang added missing-translation-status This PR does not have translation status info. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.2 labels Sep 6, 2023
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.3: #14743.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.2: #14744.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #14745.

@ran-huang ran-huang added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Oct 13, 2023
@ti-chi-bot ti-chi-bot bot removed missing-translation-status This PR does not have translation status info. labels Oct 13, 2023
@ran-huang ran-huang mentioned this pull request Oct 13, 2023
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants